Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22325 BRS74RC: Update version number to 74.1 #2613

Merged
merged 1 commit into from
Sep 26, 2023
Merged

ICU-22325 BRS74RC: Update version number to 74.1 #2613

merged 1 commit into from
Sep 26, 2023

Conversation

rp9-next
Copy link
Contributor

@rp9-next rp9-next commented Sep 20, 2023 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22325
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@rp9-next rp9-next marked this pull request as ready for review September 21, 2023 05:54
@mihnita
Copy link
Contributor

mihnita commented Sep 22, 2023

I just merged a PR that simplifies the versioning on the Java side (#2624)

It is easy to update all the pom versions:

mvn versions:set -DnewVersion=74.1.0 -DgenerateBackupPoms=false

But there are still places to update in 2 files:

  • In icu4j/pom.xml the api.doc.version property.
    Maybe. It is now "${icu.major.version} Release Candidate", which makes it "74 Release Candidate".
    But will need updating for release.
    That is only used in the Javadoc.
  • A few variables in icu4j/releases_tools/api_reports.sh
    • artifact_version
    • api_report_version
    • api_report_prev_version

@markusicu
Copy link
Member

Thanks Mihai!
Could you please rebase this PR, make the additional changes for ICU4J and add a commit for those?

@echeran
Copy link
Contributor

echeran commented Sep 23, 2023

@mihnita @markusicu I added commits to update the relevant release process docs based on what I saw from Mihai's comments. Please review that I got it correct. Also, the version numbers have already been set correctly by Mihai's PR. I merged the latest from main into this branch to pick up those changes.

@mihnita
Copy link
Contributor

mihnita commented Sep 23, 2023

I can't rebase / merge, it is grayed out.
And I can't see any pom.xml changes.

Also, the version numbers have already been set correctly by Mihai's PR.
I merged the latest from main into this branch to pick up those changes.

?
What I submitted still uses <version>74.0.1-SNAPSHOT</version>

@markusicu
Copy link
Member

For reference:

72:

Inconsistent, but my memory is that we have tried to move some of these changes forward to reduce work.
@yumaoka @pedberg-icu @richgillam FYI

mihnita
mihnita reviewed Sep 25, 2023
View reviewed changes
docs/processes/release/tasks/versions.md
`mvn versions:set -DnewVersion=75.0.1-SNAPSHOT` is executed.

4. Update the `api.doc.version` property.
Edit the root pom file at `icu4j/pom.xml` and manually make this change:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD: we might consider using the version directly instead of ${icu.major.version}.

That way one can change it from command line:

mvn versions:set-property -DnewVersion="75 Release Candidate" -Dproperty=api.doc.version

Or maybe remove "Release Candidate" completely.
"In my book" RC means: if there are no problems found then this is promoted to GA.

Using "Release Candidate" anywhere means that even if everything is perfect, one has to remove such and rebuild in order to release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: not actionable for this PR, of course.

mihnita
mihnita previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

markusicu
markusicu previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

icu4j/main/currdata/pom.xml Outdated Show resolved Hide resolved
@echeran echeran dismissed stale reviews from markusicu and mihnita via a62dfd9 September 25, 2023 22:00
markusicu
markusicu approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx!

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu merged commit 99026f0 into unicode-org:main Sep 26, 2023
96 checks passed
@rp9-next rp9-next deleted the brs_74rc_update branch September 6, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@mihnita mihnita mihnita approved these changes

@pedberg-icu pedberg-icu Awaiting requested review from pedberg-icu

@echeran echeran Awaiting requested review from echeran

Assignees

@echeran echeran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rp9-next @mihnita @markusicu @echeran